feat: Add .NET 8.0 support for Oracle persistence provider and improve test infrastructure #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…packages dependencies, cleaned code of the files, plus some minor adjustments. Added Oracle as a persistence option in readme.
…ed net8.0 test support for Oracle.
There was a problem hiding this comment.
Pull Request Overview
This PR adds .NET 8.0 support to the Oracle persistence provider and improves the test infrastructure by implementing TestContainers for reliable containerized testing. The changes ensure the Oracle provider works seamlessly with both .NET 6.0 and .NET 8.0, while enhancing the development and testing experience.
- Adds .NET 8.0 target framework support to Oracle persistence provider and tests
- Implements TestContainers for Oracle database testing to replace manual setup
- Removes unused imports and cleans up code across multiple test scenario files
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| WorkflowCore.Persistence.Oracle.csproj | Adds .NET 8.0 target framework and version-specific Entity Framework packages |
| WorkflowCore.Tests.Oracle.csproj | Adds .NET 8.0 support and TestContainers.Oracle package reference |
| OracleSetup.cs | Implements TestContainers-based Oracle database setup replacing manual configuration |
| Multiple scenario test files | Removes unused imports (System, WorkflowCore.Tests.Oracle namespace) |
| ServiceCollectionExtensions.cs | Parameter name correction and unused import cleanup |
| README files | Updates documentation to include Oracle provider and usage examples |
| GitHub Actions workflow | Adds Oracle tests to CI/CD pipeline |
test/WorkflowCore.Tests.Oracle/OraclePersistenceProviderFixture.cs
Outdated
Show resolved
Hide resolved
… Fixed a word in readme. Added .NET 9.0.x SDK to Oracle-Tests workflow job.
danielgerlag
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This PR adds .NET 8.0 support to the Oracle persistence provider and improves the overall test infrastructure and documentation. The main highlight is the addition of .NET 8.0 compatibility, making the Oracle provider fully supported on the latest .NET version.
Describe your implementation or design
Tests
Breaking change
No breaking changes. This is a backward-compatible enhancement that adds .NET 8.0 support while maintaining full compatibility with .NET 6.0.
Additional context
The Oracle persistence provider now fully supports the latest .NET 8.0 framework, making it ready for modern .NET applications. The improved test infrastructure ensures reliable testing across different environments, and the enhanced documentation makes it easier for developers to integrate Oracle persistence into their WorkflowCore applications.